Add Battenberg Painting #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
+ Coverage 91.16% 91.20% +0.04%
==========================================
Files 190 192 +2
Lines 20976 21157 +181
==========================================
+ Hits 19122 19296 +174
- Misses 1854 1861 +7 ☔ View full report in Codecov by Sentry. |
x-sheep
requested changes
Jul 10, 2024
Co-authored-by: Lennard Sprong <[email protected]>
x-sheep
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to determine where this genre originates from. The spelling of the first word in its name is wildly inconsistent. "Battenberg" seems to be supported by more sources, including the GAPP team, puzsq and Puzzle Duel, but "Battenburg" is used in Eric Fox's genre list and about equally common in casual conversation. I set the ID to just "batten" to avoid any potential mistakes arising from that.
The traditional symbol used for clues in this genre is a 2x2 checkerboard. Not a fan of this design choice but I kept it - just gave it a border so it looks a lot less trippy than in every other puzzle player I've seen it in once you shade around it.
When moving between cells adjacent to a common clue, and only then, mouse input follows rules similar to dynasty shading. Players have to shade checkerboard patterns a lot in this genre, so it seemed important to make that easy, and this solution has the best feel out of everything I tried.